Skip to content

audit(aws): surface OpenSearch RI tag-failure for ops monitoring (closes #250)#831

Open
cristim wants to merge 3 commits into
feat/multicloud-web-frontendfrom
fix/250-wave10
Open

audit(aws): surface OpenSearch RI tag-failure for ops monitoring (closes #250)#831
cristim wants to merge 3 commits into
feat/multicloud-web-frontendfrom
fix/250-wave10

Conversation

@cristim
Copy link
Copy Markdown
Member

@cristim cristim commented May 28, 2026

Summary

  • Replace the freeform WARNING: log line in PurchaseCommitment with a
    structured OPENSEARCH_TAG_FAILED commitment_id=<id> error=<msg> line so
    operator dashboards and CloudWatch Logs Insights queries can alert on
    untagged RIs
  • Add runbooks/opensearch-untagged-ri.md covering background (unsupported
    reserved-instance ARN type), manual re-tagging steps, and the fallback for
    when AWS still rejects the call
  • Update the PurchaseCommitment comment to reference the runbook

Test plan

  • TestPurchaseCommitment_TagFailure_StructuredLog (new): verifies
    OPENSEARCH_TAG_FAILED sentinel and commitment_id= field appear in the
    log, purchase result is still Success=true, and account ID is absent from
    the line
  • Existing TestClient_PurchaseCommitment_AddTagsFailureDoesNotFailPurchase
    remains green (non-fatal contract unchanged)
  • go vet ./providers/aws/services/opensearch/... clean

@cristim
audit(aws): surface OpenSearch RI tag-failure for ops monitoring (closes
fa0df02 
 #250)

Emit a structured OPENSEARCH_TAG_FAILED log line when the best-effort
AddTags call after RI purchase fails, so operator dashboards can alert on
untagged reservations. Add runbooks/opensearch-untagged-ri.md with manual
remediation steps and background on the unsupported ARN type. Update the
PurchaseCommitment comment to reference the runbook.
@cristim cristim added triaged Item has been triaged priority/p3 Polish / idea / may never ship severity/low Minor harm urgency/eventually No deadline impact/internal Team-internal only effort/xs Trivial / one-liner type/chore Maintenance / non-user-visible labels May 28, 2026
@cristim
Copy link
Copy Markdown
Member Author

cristim commented May 28, 2026

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 28, 2026 •
edited
Loading

Warning

Review limit reached

@cristim, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 56 minutes and 2 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: cf4d4e3b-c738-4ee7-9ffb-a89ecef67c83

📥 Commits

Reviewing files that changed from the base of the PR and between 4956d66 and e48bf52.

📒 Files selected for processing (3)
  • providers/aws/services/opensearch/client.go
  • providers/aws/services/opensearch/client_test.go
  • runbooks/opensearch-untagged-ri.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/250-wave10

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 28, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@cristim
Copy link
Copy Markdown
Member Author

cristim commented May 30, 2026

@coderabbitai full review

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 30, 2026

✅ Actions performed

Full review triggered.

@cristim
fix(ci): re-trigger pre-commit after transient setup-go SHA fetch fai…
c35a315 
…lure (#831)

The prior run failed because GitHub's CDN returned a 404 for the
pinned actions/setup-go SHA at download time (transient infrastructure
issue). No code changes are needed; this empty commit re-triggers CI.
@cristim
Copy link
Copy Markdown
Member Author

cristim commented Jun 1, 2026

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 1, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@cristim
Copy link
Copy Markdown
Member Author

cristim commented Jun 4, 2026

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 4, 2026

Rate Limit Exceeded

@cristim have exceeded the limit for the number of chat messages per hour. Please wait 39 minutes and 22 seconds before sending another message.

@cristim
docs(runbooks): add code-fence languages to satisfy markdownlint MD04…
e48bf52 
…0 (refs #250)

Three bare ``` fences in runbooks/opensearch-untagged-ri.md lacked a language
specifier, causing MD040 failures in CI. Added `text` to each (log-output and
ARN example blocks).
@cristim
Copy link
Copy Markdown
Member Author

cristim commented Jun 5, 2026

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 5, 2026 •
edited
Loading

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

effort/xs Trivial / one-liner impact/internal Team-internal only priority/p3 Polish / idea / may never ship severity/low Minor harm triaged Item has been triaged type/chore Maintenance / non-user-visible urgency/eventually No deadline

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@cristim